PacketParserUtils.parseSASLFailure throws an exception if there is a 'text' element inside the 'failure'

Igor_Khomenko · December 11, 2014, 11:06am

According to XMPP doc it’s possible to have the OPTIONAL descriptive text in inside ‘failure’ element

but smack throws an exception

for example, here is an example of ‘failure’ which causes an exception in asmack

D/SMACK﹕ RCV (0): Password not verified

12-11 12:37:06.311 1709-1856/com.ben.snippets W/SASLError﹕ Could not transform string ‘text’ to SASLError

java.lang.IllegalArgumentException: text is not a constant in org.jivesoftware.smack.sasl.SASLError

at java.lang.Enum.valueOf(Enum.java:198)

at org.jivesoftware.smack.sasl.SASLError.valueOf(SASLError.java:22)

at org.jivesoftware.smack.sasl.SASLError.fromString(SASLError.java:48)

at org.jivesoftware.smack.sasl.SASLMechanism$SASLFailure.(SASLMechanism.java :357)

at org.jivesoftware.smack.util.PacketParserUtils.parseSASLFailure(PacketParserUtil s.java:720)

at org.jivesoftware.smack.tcp.PacketReader.parsePackets(PacketReader.java:255)

at org.jivesoftware.smack.tcp.PacketReader.access$000(PacketReader.java:49)

at org.jivesoftware.smack.tcp.PacketReader$1.run(PacketReader.java:83)

I use asmack 4.0.6

Flow · December 11, 2014, 12:53pm

This has been fixed a while ago in 4.1. I’m not sure if I’m going to backport the fix to 4.0.

Igor_Khomenko · December 11, 2014, 1:02pm

Where I can find this fix?
have just downloaded the latest 4.1 alpha snapshot and this method looks the same there

Flow · December 11, 2014, 2:56pm

Igor_Khomenko · December 11, 2014, 4:23pm