My patches

Spark Spark Dev
1

here is my first patch fo? spark.

Here is fixing of this problem : http://www.igniterealtime.org/issues/browse/SPARK-903

I created eventlistener for BookmarksUI. Now there are only two events (add bookmark and remove bookmark), later i will create more. if it will be need.

And there is new version of bookmarksPlugin (in spark menu). Please test it and tell me all bugz you find.
bookmarks_fixing_SPARK_903.patch (10017 Bytes)

2

I have applied your patch in my test environment. I don’t have OS X, so i cant see is it fixing the problem. I was testing is it have any effect on the other issue http://www.igniterealtime.org/issues/browse/SPARK-994 (Windows). It doesn’t. Anyway, i still can’t attach files to the tickets, but i have added your patch to a table here http://www.igniterealtime.org/community/docs/DOC-1652 with a link to this thread.

3

This problem was not only in Mac OX. I find this in Linux and into Windows. And tested this in this OS. All works.

I will try to fix this http://www.igniterealtime.org/issues/browse/SPARK-994. If i understanded you right, you speaks about showing bookmarks menu when you adding new first bookmark.

4

konstantin.zolotarev wrote:

If i understanded you right, you speaks about showing bookmarks menu when you adding new first bookmark.

Yes. And also after removing all bookmarks Bookmarks menu doesnt disappear until next login.

5

Please try this one, install it on my previous patch :
bookmarks_menu_hiding_SPARK-994.patch (7005 Bytes)

6

The last patch is failing in NetBeans:

02.01.2009 12:42:40 ===========================================================================
— Successfully Patched —

— Failed —
D:\My Documents\JiveSoftware\Spark\src\BookmarkPlugin.java (Index: 9, Size: 0 )
And when i try to aply directly on BookmarkPlugin.java i get:

02.01.2009 12:44:09 ===========================================================================
— Successfully Patched —

— Failed —
D:\My Documents\JiveSoftware\Spark\src\java\org\jivesoftware\sparkimpl\plugin\bookmar ks\BookmarkPlugin.java (Cannot apply hunk @@ 13 )
As a source base i’m using svn copy of 2008.11.15 and the first patch is applied already.

7

Ok. this is patch for 2 bugz. Install it into source from svn. You may delete 2 previous patches. Test this patch please.
bookmarks_fixing_SPARK_903+SPARK-994.patch (11310 Bytes)

8

The patch was applied successfully now, but still doesnt fix 994 problem.

9

I see that you are fixing it in conferences part. But the problem is with the main menu. Maybe there are some other places related to Bookmarks in the source.

10

Hi there =)

I just found a little bug in my patch. Some time BookmarkPlugin loading earlier than BookmarkUI. In that case BookmarkListener didn’t work.

Here attached little fixing of this problem.
123.diff.zip (846 Bytes)

11

So, is this a patch for a patch? Can you please attach the fixed patch?

12

This is patch for the sources i downloaded from svn yesterday.

13

I have reopened SPARK-994 and attached your patch.