Skip navigation
1374 Views 8 Replies Latest reply: Nov 28, 2013 11:08 PM by Jorun Gordan RSS
Jorun Gordan Bronze 12 posts since
Mar 13, 2012
Currently Being Moderated

Mar 13, 2012 7:52 AM

bug: fix documentation FileTransfer

Hi.

 

Partly, I had a hard time understanding what those receiveFile(..) methods of IncomingFileTransfer is doing exactly.

 

Could you please fix the description in the following regards:

 

a) receiveFile(File) "throws an XMPPException when the transfer fails. This is not the case - it throws this exception if the negotiation fails

 

b) please clarify, that the state of a FileTransfer is only updated if using the receiveFile(File) method, not the receiveFile() method --- or even better, fix this.

 

TIA

    • Flow KeyContributor 605 posts since
      Jan 11, 2007
      Currently Being Moderated
      Jun 9, 2012 6:51 AM (in response to Jorun Gordan)
      Re: bug: fix documentation FileTransfer

      a) Well if the negotiation failes, the file transfer failes and a Exception is thrown. So the documention is not wrong. It's just no indicator that the stream will be stable until the end of the transfer.

       

      b) I am not sure if this is possible. The receiveFile() is sync and receiveFile(File) is async. How can the state of the sync call be updated, how do you even monitor the state? Maybe I am just not getting it. Patches are always welcome. :-)

       

      c) If that's so then it should be at least documented. Fixing may not be easy, if it's not reproduceable.

       

      Flow

      • rcollier KeyContributor 982 posts since
        Mar 4, 2009
        Currently Being Moderated
        Jun 7, 2012 12:56 PM (in response to Flow)
        bug: fix documentation FileTransfer

        a) What Flow said.

        b) Flow is correct.  Using this method the developer is taking responsibility for the actual transfer, so Smack does not internally track its progress since the developers own code is reading the parts.

        c) Have to look into that one.

More Like This

  • Retrieving data ...

Bookmarked By (0)

Legend

  • Correct Answers - 10 points
  • Helpful Answers - 5 points