Skip navigation
Up to Discussions in OpenYMSG
2505 Views 2 Replies Latest reply: Nov 13, 2008 6:44 PM by alex_1 RSS
alex_1 Bronze
alex_1
26 posts since
Feb 25, 2006
Currently Being Moderated

Nov 8, 2008 2:08 PM

connectionClosed isn't called

I am seing that  the callback for connectionClosed doesn't get called reliably.

Yet the session status does get set to FAILED when I check later.

Anyone seing this problem?

Are there other callbacks I should be listenig to instead to know when we've been disconnected?

 

 

I was looking into why email notifications were not working right and THIS IS WHY.   Can't notify on a disconnected session. So fixing this problem would fix both.

  • alex_1 Bronze
    alex_1
    26 posts since
    Feb 25, 2006
    Currently Being Moderated
    Nov 11, 2008 1:49 PM (in response to alex_1)
    Re: connectionClosed isn't called

    Don't we need:

     

    Session.java:

    line 1825:  sessionStatus = SessionState.FAILED;
    new line:   eventDispatchQueue.append(ServiceType.LOGOFF);

     

    This to tell people session died?

    Any more places this is needed?

     

    Someone with commit privs - is this something that should be committed to the tree?

  • alex_1 Bronze
    alex_1
    26 posts since
    Feb 25, 2006
    Currently Being Moderated
    Nov 13, 2008 6:44 PM (in response to alex_1)
    Re: connectionClosed isn't called

    And one other place:

    session:2969:

     

        void sendExceptionEvent(Exception e, String msg) {
    new line:        sessionStatus = SessionState.FAILED;
            SessionExceptionEvent se = new SessionExceptionEvent(Session.this, msg,
                    e);
            eventDispatchQueue.append(se, ServiceType.X_EXCEPTION);
        }

     

     

    This looks like a good idea....

     

    Anyone wants to concurr or offer a better one?

     

     

    I did it based on this dump:

     

    Input exception: Source: InputThread
    java.net.SocketException: Connection reset
        at java.net.SocketInputStream.read(SocketInputStream.java:168)
        at java.io.BufferedInputStream.fill(BufferedInputStream.java:218)
        at java.io.BufferedInputStream.read1(BufferedInputStream.java:258)
        at java.io.BufferedInputStream.read(BufferedInputStream.java:317)
        at org.openymsg.network.YMSG9InputStream.readBuffer(YMSG9InputStream.java:171)
        at org.openymsg.network.YMSG9InputStream.readPacket(YMSG9InputStream.java:68)
        at org.openymsg.network.DirectConnectionHandler.receivePacket(DirectConnectionHand ler.java:159)
        at org.openymsg.network.InputThread.run(InputThread.java:70)

     

    InputThread.java:70 being the key place that handles this.

     

    Again, if you are developer on this thing: please change repository as I have no access to it.

More Like This

  • Retrieving data ...

Bookmarked By (0)

Legend

  • Correct Answers - 10 points
  • Helpful Answers - 5 points