Ignite Realtime: Spark 2.6.0B2 BUG: Empty groups and...

Skip navigation

Up to Discussions in Spark Support

6388 Views 12 Replies Latest reply: Feb 19, 2010 12:53 AM by Guenther Niess

Walter Ebeling

142 posts since
Oct 25, 2006

Currently Being Moderated

Oct 8, 2008 7:32 AM

Spark 2.6.0B2 BUG: Empty groups and missing search bar

Hi

I have tracked down a bug in 2.6.0.B2 related to users in the roster that belong to no group.

Symptoms:

- No user is shown as online, even if they are online.

- The IM Gateway buttons are not showing up

- Not all users of the rooster are shown in the offline group

- The search ba is disappearing

How to reproduce:

-Fresh Install of OF 3.6.0a (bug shows also on 3.5.2)

-Install the user import export 2.2.1 plugin

- Load this user:

<?xml version="1.0" encoding="UTF-8"?>

<Openfire>
<User>
    <Username>Donald.duck</Username>
    <Password>password</Password>
    <Email>walter.ebeling@mycompany.com</Email>
    <Name>Walter Ebeling</Name>
    <CreationDate>1171038962547</CreationDate>
    <ModifiedDate>1171038962547</ModifiedDate>
    <Roster>
      <Item jid="some.one@jabber.int.kn" askstatus="-1" recvstatus="-1" substatus="3" name="Some One">
        <Group></Group>
      </Item>
    </Roster>
</User>
</Openfire>

- Start 2.6.0 B2 and log on to the server as Donald.Duck with the password "password"

I would consider this a major bug in 2.6.0.b2. Beta 1 was not showing this.

Kind regards

Walter

Like (0)

Tags: spark, bug, roster, bug_report, 2.6.0

wroot
5,228 posts since
Jan 24, 2005

Currently Being Moderated

Oct 8, 2008 12:36 PM (in response to Walter Ebeling)
Re: Spark 2.6.0B2 BUG: Empty groups and missing search bar

Well, i can reroduce this. But i'm not good in this xml scheme, so i'm not sure if there is nothing wrong with that scheme. What are those askstatus, recstatus and substatus about? Are you saying this was working fine with 2.6.0 Beta 1 of Spark? I can confirm that i can normally login with such imported user with Exodus and i see online and offline users normally. This could be an issue of Spark, but i will let someone with more knowledge to confirm that and maybe file a bug ticket in JIRA.

Report Abuse

Like (0)
- Walter Ebeling
  142 posts since
  Oct 25, 2006
  
  Currently Being Moderated
  
  Oct 8, 2008 2:28 PM (in response to wroot)
  Re: Spark 2.6.0B2 BUG: Empty groups and missing search bar
  
  Hi wroot
  
  the imported user works well with 2.5.8. and 2.6.0b1 (on Windows 2000). The bug is showing on OF 3.5.2. (mySQL datebase on Linux) and 3.6.0a (embbeded database on W2K).
  
  The XML is produced by the user invite plugin on our production system. The import on the test system is only affecting the database of OF. The XML is not the cause of the problem.
  
  The status information is related to the presence control established on our production server. The visibility of the presence status of a user is controlled by the status in the XML. That's all.
  
  I have taken a look in the database. The entry groupName in the table jiveRosterGroups is empty (not a blank character) for the contact. The XML send for the server to the client looks like this (captured by the debug dialog):
  
  <iq type="result" id="T9wVg-3" to="donald.duck@dew05947.ger.win.int.kn/spark"><query xmlns="jabber:iq:roster">
  <item jid="some.one@jabber.int.kn" name="Some One" subscription="both"><group></group></item></query></iq>
  
  We have to take a look at the XML parser of Spark.
  
  Regards
  
  Walter
  
  Report Abuse
  
  Like (0)
  - Walter Ebeling
    142 posts since
    Oct 25, 2006
    
    Currently Being Moderated
    
    Oct 24, 2008 1:58 PM (in response to Walter Ebeling)
    Re: Spark 2.6.0B2 BUG: Empty groups and missing search bar
    
    This issue has a patch that may be included in 2.6.0 as it was send to the maintainer of Spark
    
    Report Abuse
    
    Like (0)
    - wroot
      5,228 posts since
      Jan 24, 2005
      
      Currently Being Moderated
      
      Nov 16, 2008 4:55 AM (in response to Walter Ebeling)
      Re: Spark 2.6.0B2 BUG: Empty groups and missing search bar
      
      Walter, do you know is there a JIRA ticket for that bug? Also, can you attach your aptch here, so i can link to it in the Spark Patches Waiting for Trunk document?
      
      Report Abuse
      
      Like (0)
      - winsrev
        270 posts since
        Jan 28, 2007
        
        Currently Being Moderated
        
        Nov 16, 2008 9:05 AM (in response to wroot)
        Re: Spark 2.6.0B2 BUG: Empty groups and missing search bar
        
        I recieved a copy of the patch, I have it within my inbox. Thanks.
        
        Report Abuse
        
        Like (0)
        
        Walter Ebeling
        142 posts since
        Oct 25, 2006
        
        Currently Being Moderated
        
        Nov 17, 2008 12:06 AM (in response to winsrev)
        Re: Spark 2.6.0B2 BUG: Empty groups and missing search bar
        
        Hello Winserv,
        
        that patch is incomplete and invalid. Sorry.
        
        Walter
        
        Report Abuse
        
        Like (0)
      - Walter Ebeling
        142 posts since
        Oct 25, 2006
        
        Currently Being Moderated
        
        Nov 17, 2008 12:07 AM (in response to wroot)
        Re: Spark 2.6.0B2 BUG: Empty groups and missing search bar
        
        Hi Wroot
        
        there is no bug for that in Jira
        Walter
        
        Report Abuse
        
        Like (0)
Sunshine
10 posts since
Oct 30, 2008

Currently Being Moderated

Dec 2, 2008 9:19 AM (in response to Walter Ebeling)
Re: Spark 2.6.0B2 BUG: Empty groups and missing search bar

Our CIO also reported this problem. Has a support ticket already been created?
Sun Solaris 10
MS Windows XP sp2
Java 1.5.0_16-b02
Spark 2.6.0 b2
OpenFire 3.5.2

Report Abuse

Like (0)
- Walter Ebeling
  142 posts since
  Oct 25, 2006
  
  Currently Being Moderated
  
  Mar 21, 2009 1:31 AM (in response to Sunshine)
  Re: Spark 2.6.0B2 BUG: Empty groups and missing search bar
  
  Hi
  
  a patch was submitted and should be checked into the trunk of Spark soon.
  
  Walter
  
  Report Abuse
  
  Like (0)
Guenther Niess
304 posts since
Jun 19, 2008

Currently Being Moderated

Feb 18, 2010 6:50 AM (in response to Walter Ebeling)
Re: Spark 2.6.0B2 BUG: Empty groups and missing search bar

I've created SMACK-294 and committed a patch to the trunk which improves the handling of empty groups. But in my opinion there are still more bugs with empty groups. First of all, I think empty and no group should be handled in the same way. Which means the <group></group> element should be unnecessary and ignored by the user import-export plugin. Further more spark should allow creating a new buddy with isn't member of any group, currently you have to trick spark with a whitespace character as groupname, which generates this stupid empty groups. So I think a <item ...><group></group></item> stanza is allowed but shouldn't be sent anyway since it's useless, ugly and only produces more load.

Report Abuse

Like (0)
- Walter Ebeling
  142 posts since
  Oct 25, 2006
  
  Currently Being Moderated
  
  Feb 19, 2010 12:03 AM (in response to Guenther Niess)
  Re: Spark 2.6.0B2 BUG: Empty groups and missing search bar
  
  First of all thanks for your time to look into this issue.
  
  I have stumbled across this issue because of users that were in a shared group and subsequently removed from that group. The stories goes like this: A users shares the group "Disneyland" and he recieves the contacts Mickey Mouse, Donald Duck. Now Donald is in his Roster, and belongs to the group Disnesland. If Donald is now expelled from Disneyland, the contact still stays in the Spark roster bust the server does not transport "Disneyland" in the <group> element.
  
  We have played with the Spark Implementation a it an decided to use a default group for contacts with empty groups.
  
  Walter
  
  Report Abuse
  
  Like (0)
- Guenther Niess
  304 posts since
  Jun 19, 2008
  
  Currently Being Moderated
  
  Feb 19, 2010 12:53 AM (in response to Guenther Niess)
  Re: Spark 2.6.0B2 BUG: Empty groups and missing search bar
  
  Created ~~OF-349~~ and committed a patch which ignores empty group elements.
  
  Report Abuse
  
  Like (0)

Go to original post

Legend

Correct Answers - 10 points
Helpful Answers - 5 points