Ignite Realtime: Problems with Trunk builds of Openfire...

Skip navigation

Up to Discussions in Openfire Dev

1567 Views 7 Replies Latest reply: Sep 2, 2010 2:56 PM by LG

metamaterial

7 posts since
Apr 16, 2010

Currently Being Moderated

Aug 6, 2010 4:18 PM

Problems with Trunk builds of Openfire and Tinder

Wanted to report a few things.

1. The latest build of openfire references an older version of tinder.jar. It's pre- 11520 as protected JID jid = null; is missing in AbstractComponent

2. Having rebuild the latest tinder.jar and updated openfire with this library discovered that the latest changes to JID had messed things up. Namely JID.toString() now returns null@component.domain.com for nodeless jids (components) so the components and plugins are pretty much disfunctional. Reverting to older code base for JID.java solved the problem.

If this hasn't been reported yet looks like #1 is the reason from # didn't surface right away.

cheers

Like (0)

Tags: bug, openfire, build, trunk, tinder

Guus der Kinderen
770 posts since
Sep 8, 2005

Currently Being Moderated

Aug 8, 2010 5:36 AM (in response to metamaterial)
Re: Problems with Trunk builds of Openfire and Tinder

Thanks for reporting this, Andrei. I've noticed the problem myself, and actually fixed it, but neglected to check in the fix. I probably misseed my morning coffee that day. As you've bothered to do a proper report, I've created a proper JIRA issue for this: TINDER-45

I'll check in the fix momentarily (most likely before you read this response).

Report Abuse

Like (0)
- metamaterial
  7 posts since
  Apr 16, 2010
  
  Currently Being Moderated
  
  Aug 8, 2010 5:11 PM (in response to Guus der Kinderen)
  Re: Problems with Trunk builds of Openfire and Tinder
  
  Any time. I wasn't sure on the rule for reporting bugs as I am new to the community but please advise.
  
  Report Abuse
  
  Like (0)
Kevin Day
21 posts since
Apr 6, 2006

Currently Being Moderated

Sep 2, 2010 9:47 AM (in response to metamaterial)
Re: Problems with Trunk builds of Openfire and Tinder

FYI - the fix for this issue was not complete. toBareJID() also needs to be adjusted as follows:

public String toBareJID() {
         final StringBuilder sb = new StringBuilder();
         if (this.node != null) {
             sb.append(this.node);
             sb.append('@');
         }
         sb.append(this.domain);
         return sb.toString();
     }

This problem is causing plugins to send incorrect information in disco responses - causing all sorts of havoc.

Report Abuse

Like (0)
- LG
  6,130 posts since
  Dec 13, 2005
  
  Currently Being Moderated
  
  Sep 2, 2010 1:27 PM (in response to Kevin Day)
  Re: Problems with Trunk builds of Openfire and Tinder
  
  Hi Kevin, as far as I can tell "toBareJID" should return a bare JID which consists of node@domain. So one should at least update the javadoc that this method does not throw an exception when the node is missing.
  @Guus: Why is toBareJID() not final, does one need to be able to overwrite it?
  
  Report Abuse
  
  Like (0)
- Guus der Kinderen
  770 posts since
  Sep 8, 2005
  
  Currently Being Moderated
  
  Sep 2, 2010 2:01 PM (in response to Kevin Day)
  Re: Problems with Trunk builds of Openfire and Tinder
  
  Thanks for reporting this, Kevin. I've added ~~OF-399~~ to track the Openfire-sided issue. I've also updated the original ~~TINDER-45~~ issue.
  
  @LG: Perhaps you're right - this code is not designed to be extensible, as far as I can see. If we're going to consider making things final to explicitly forbid this, I'd like to review the entire Tinder project in one go, and have it done all at once though.
  
  Report Abuse
  
  Like (0)
  - Guus der Kinderen
    770 posts since
    Sep 8, 2005
    
    Currently Being Moderated
    
    Sep 2, 2010 2:03 PM (in response to Guus der Kinderen)
    Re: Problems with Trunk builds of Openfire and Tinder
    
    Tonights nightly builds will generate Openfire distributables that include a fix for this issue. Nightlies are being build by our Bamboo instance (http://bamboo.igniterealtime.org) and are also available in the download section of our we website
    
    Report Abuse
    
    Like (0)
  - LG
    6,130 posts since
    Dec 13, 2005
    
    Currently Being Moderated
    
    Sep 2, 2010 2:56 PM (in response to Guus der Kinderen)
    Re: Problems with Trunk builds of Openfire and Tinder
    
    Yeah, one should review the whole project, same for Openfire.
    The JID class may be one which should we defined final and which should not be cloneable.
    http://www.owasp.org/index.php/Java_leading_security_practice looks fine. We could add it to Guidelines for Smack Contributors and Becoming a Contributing Member.
    
    Report Abuse
    
    Like (0)

Go to original post

Legend

Correct Answers - 10 points
Helpful Answers - 5 points

Aug 6, 2010 4:18 PM

Problems with Trunk builds of Openfire and Tinder

Actions

More Like This

Bookmarked By (0)

Legend