Ignite Realtime: Pacekt filter i18n

Skip navigation

Up to Discussions in Packet Filter

3550 Views 6 Replies Latest reply: Jan 2, 2010 10:08 AM by Guus der Kinderen

drencrom2

4 posts since
Nov 23, 2009

Currently Being Moderated

Nov 23, 2009 5:15 AM

Pacekt filter i18n

I have modified the packet filter plugin code to add complete support for i18n. There was some work done but it was far from complete. I`ve also included a spanish translation file.

Here I attach the patch for your consideration.

Best regards

Attachments:

packetFilter.patch.zip (5.0 K)

Like (0)

Daryl Herzmann
1,086 posts since
Mar 12, 2005

Currently Being Moderated

Nov 23, 2009 5:58 AM (in response to drencrom2)
Re: Pacekt filter i18n

Thanks,

I filed this as ~~OF-83~~

daryl

Report Abuse

Like (0)
- drencrom2
  4 posts since
  Nov 23, 2009
  
  Currently Being Moderated
  
  Nov 23, 2009 9:50 AM (in response to Daryl Herzmann)
  Re: Pacekt filter i18n
  
  Thank you for your response but I have just found a couple of bugs in my patch. I'm sending a new patch here with those bugs corrected. Sorry for the inconvenience.
  
  Attachments:
  
  packetFilter.patch.zip (5.0 K)
  
  Report Abuse
  
  Like (0)
  - Nate Putnam
    133 posts since
    Oct 23, 2006
    
    Currently Being Moderated
    
    Nov 24, 2009 10:01 PM (in response to drencrom2)
    Re: Pacekt filter i18n
    
    Thanks for the patch!
    
    Daryl,
    
    Thanks for filing. I'll work with Gato to get this checked in. He'll have to do the proof reading
    
    Report Abuse
    
    Like (0)
  - Guus der Kinderen
    777 posts since
    Sep 8, 2005
    
    Currently Being Moderated
    
    Jan 2, 2010 10:04 AM (in response to drencrom2)
    Re: Pacekt filter i18n
    
    Sadly, this patch does not work. The provided JSPs in the monitoring packetFilter plugin do not compile.
    
    Report Abuse
    
    Like (0)
    - drencrom2
      4 posts since
      Nov 23, 2009
      
      Currently Being Moderated
      
      Jan 2, 2010 10:00 AM (in response to Guus der Kinderen)
      Re: Pacekt filter i18n
      
      That's strange. I made the patch against the plugin in the OF 3.6.4 sources. Are you trying with this same sources?
      Could you tell me which files do not compile so I can check with my sources? I have this plugin workin in production with this patch.
      
      Also I don't understand the reference to the monitoring plugin. I did not intend to make any modifications to this plugin, only to the packet filter. Maybe I made a mistake when creating the patch file and included unintended modifications to other plugins.
      
      Regards
      Jorge
      
      Report Abuse
      
      Like (0)
      - Guus der Kinderen
        777 posts since
        Sep 8, 2005
        
        Currently Being Moderated
        
        Jan 2, 2010 10:08 AM (in response to drencrom2)
        Re: Pacekt filter i18n
        
        Disregard the reference to the Monitoring plugin. I've been working on that yesterday, I think it is haunting me.
        
        I have applied your patch to the current trunk of Openfire, and recompiled Openfire and the monitoring plugin. During the part of the buildfile where the JSPs get compiled, things break. I have rolled back the changes, and things work fine again.
        
        Report Abuse
        
        Like (0)

Go to original post

Nov 23, 2009 5:15 AM

Pacekt filter i18n

Actions

More Like This

Bookmarked By (0)