Skip navigation
4100 Views 6 Replies Latest reply: Dec 14, 2009 11:17 AM by deradam RSS
deradam Bronze 6 posts since
Dec 11, 2009
Currently Being Moderated

Dec 11, 2009 8:10 AM

Bug in ExternalComponent

Hi,

 

I have written an external component implementing the Component interface which I then add to the ExternalComponentManager. Inside this method my component is wrapped into the ExternalComponent, which does some stuff like starting the component, calling the process(Packet) method and so on.

 

However, if I remove my component from the ExternalComponentManager, it calls shutdown on the wrapper, but the wrapper does not call it on the wrapped component. The consequence is, that my component never receives anything to shutdown, which is very problematic!

 

ExternalComponent.class (lines 370 - 373)

 

public void shutdown() {
        shutdown = true;
        disconnect();
}

 

Should be:

 

public void shutdown() {
         shutdown = true;

        // Notify the component to shutdown
         component.shutdown();

         disconnect();

}

 

Cheers,

Adam

  • Daryl Herzmann KeyContributor 1,527 posts since
    Mar 12, 2005
    Currently Being Moderated
    Dec 11, 2009 9:05 AM (in response to deradam)
    Re: Bug in ExternalComponent

    Thanks, filed this as OF-85 to track its resolution

     

    daryl

    • Guenther Niess KeyContributor 305 posts since
      Jun 19, 2008
      Currently Being Moderated
      Dec 13, 2009 11:08 AM (in response to Daryl Herzmann)
      Re: Bug in ExternalComponent

      Hi, thanks! I've reviewed and commited your patch.

      • Daryl Herzmann KeyContributor 1,527 posts since
        Mar 12, 2005
        Currently Being Moderated
        Dec 13, 2009 1:23 PM (in response to Guenther Niess)
        Re: Bug in ExternalComponent

        Thanks for cleaning up my improper filing niess, not sure why I placed it in Openfire, sigh...

         

        daryl

        • Guenther Niess KeyContributor 305 posts since
          Jun 19, 2008
          Currently Being Moderated
          Dec 14, 2009 9:36 AM (in response to deradam)
          Re: Bug in ExternalComponent

          Do you plan to release a new version of Whack, say 1.0.1 including the patch? Or should I build myself a new version from the sources?

          As I know it is planned to release a new version, but I don't know a schedule yet. So I would recommend to build the library from svn.

          One other things you guys should do, is setup a maven repository for all your libs. Right now I have to deploy them manually to our internal repo. If you had one, it would really ease the usage!

          I also recommanded that a few month ago, but I haven't got much response from the Jive officials.

More Like This

  • Retrieving data ...

Bookmarked By (0)

Legend

  • Correct Answers - 10 points
  • Helpful Answers - 5 points