Ignite Realtime: Is it possible to SVN commit? How do I...

Skip navigation

Up to Discussions in Openfire Dev

5735 Views 14 Replies Latest reply: Jan 10, 2010 10:36 AM by Guus der Kinderen

lkh007

7 posts since
Jun 19, 2009

Currently Being Moderated

Jun 22, 2009 7:00 PM

Is it possible to SVN commit? How do I obtain the access?

Hi, I have patches for bugs in OpenFire Server and is looking forward to contribute. How do I obtain the SVN access?

Like (0)

Daryl Herzmann
1,060 posts since
Mar 12, 2005

Currently Being Moderated

Jun 22, 2009 7:06 PM (in response to lkh007)
Re: Is it possible to SVN commit? How do I obtain the access?

Hi,

Thanks for your interest in contributing. You will want to sign this and send it in:

http://www.igniterealtime.org/ignite_contributor_agreement.pdf

Also, what sort of patches do you have?

thanks,
daryl

Report Abuse

Like (0)
- lkh007
  7 posts since
  Jun 19, 2009
  
  Currently Being Moderated
  
  Jun 22, 2009 7:27 PM (in response to Daryl Herzmann)
  Re: Is it possible to SVN commit? How do I obtain the access?
  
  Hi Daryl, thanks for your reply. It seems like there is a need to sign and fax to a US address. Since I'm not from nor in US, do you know anybody that I could submit the source code to?
  
  Report Abuse
  
  Like (0)
  - Daryl Herzmann
    1,060 posts since
    Mar 12, 2005
    
    Currently Being Moderated
    
    Jun 22, 2009 7:35 PM (in response to lkh007)
    Re: Is it possible to SVN commit? How do I obtain the access?
    
    Hi,
    
    Feel free to attach the patches to this message thread.
    
    daryl
    
    Report Abuse
    
    Like (0)
    - lkh007
      7 posts since
      Jun 19, 2009
      
      Currently Being Moderated
      
      Jun 22, 2009 7:38 PM (in response to Daryl Herzmann)
      Re: Is it possible to SVN commit? How do I obtain the access?
      
      Hi Daryl, attached is the file. Thanks.
      
      Attachments:
      
      JDBCAuthProvider.java (14.0 K)
      
      Report Abuse
      
      Like (0)
      - wroot
        6,839 posts since
        Jan 24, 2005
        
        Currently Being Moderated
        
        Jun 22, 2009 8:49 PM (in response to lkh007)
        Re: Is it possible to SVN commit? How do I obtain the access?
        
        It's better to have patches in diff format. Also, can you describe what you are trying to fix?
        
        Report Abuse
        
        Like (0)
        
        lkh007
        7 posts since
        Jun 19, 2009
        
        Currently Being Moderated
        
        Jun 22, 2009 9:11 PM (in response to wroot)
        Re: Is it possible to SVN commit? How do I obtain the access?
        
        What format do you recommend? As for the fix, I'd fixed the part which: "When using JDBCAuthProvider instead of DefaultAuthProvider, the Update Password feature fails due to wrong JDBC API call i.e. executeQuery on UPDATE queries, in the source code."
        
        Report Abuse
        
        Like (0)
        
        wroot
        6,839 posts since
        Jan 24, 2005
        
        Currently Being Moderated
        
        Jun 22, 2009 10:46 PM (in response to lkh007)
        Re: Is it possible to SVN commit? How do I obtain the access?
        
        As i said we prefer DIFF format (not a patched file itself, but a file which describes what changes has been done in the original source). Such files can be applied to a source easier. Your source editing program should be able to produce source difference files.
        
        I'm not a developer, so can you explain what problem does you patch fixes? i want to be sure that it's not duplicating the other patch.
        
        Also, what problem is with sending the fax to US? I think you can sign it, then scan to PDF and maybe send via email to matt@igniterealtime.org
        
        Report Abuse
        
        Like (0)
        
        lkh007
        7 posts since
        Jun 19, 2009
        
        Currently Being Moderated
        
        Jun 22, 2009 11:54 PM (in response to wroot)
        Re: Is it possible to SVN commit? How do I obtain the access?
        
        Hi wroot, the DIFF format is as attached. Previously I thought "diff -> different" format (too much MSN LOL), this is why I asked for which other formats you recommend . Problem is fixed as described earlier, in easier terms it would be: "Unable to Update Password if JDBC Auth Provider is used instead of Default".
        
        As for the PDF, I'll send once I get a scanner.
        
        Thanks.
        
        Attachments:
        
        diff.txt (302 bytes)
        
        Report Abuse
        
        Like (0)
        
        wroot
        6,839 posts since
        Jan 24, 2005
        
        Currently Being Moderated
        
        Jun 23, 2009 12:41 AM (in response to lkh007)
        Re: Is it possible to SVN commit? How do I obtain the access?
        
        I filed this as ~~OF-26~~ .
        
        Report Abuse
        
        Like (0)
        
        Guus der Kinderen
        770 posts since
        Sep 8, 2005
        
        Currently Being Moderated
        
        Jan 10, 2010 10:36 AM (in response to wroot)
        Re: Is it possible to SVN commit? How do I obtain the access?
        
        Thanks for your fix. I've applied it to Openfire's sources. Your fix will be part of Openfire 3.6.5.
        
        Report Abuse
        
        Like (0)
- lkh007
  7 posts since
  Jun 19, 2009
  
  Currently Being Moderated
  
  Jun 22, 2009 9:16 PM (in response to Daryl Herzmann)
  Re: Is it possible to SVN commit? How do I obtain the access?
  
  Hi Daryl, is there any other ways to join as Contributor other than signing and faxing? I just wonder how do others contribute if they are not from nor in US
  
  Report Abuse
  
  Like (0)
  - Walter Ebeling
    577 posts since
    Oct 25, 2006
    
    Currently Being Moderated
    
    Jun 23, 2009 1:02 AM (in response to lkh007)
    Re: Is it possible to SVN commit? How do I obtain the access?
    
    I have send my contributors agreement to cstux for my Spark patches. Since he is the "maintainer" of Spark, he reviews the changes and usually add's some additional stuff to them. In the end he is doing the commits.
    
    The SVN commits rights are not handed out lightly by Jive/Ignite to keep the quality of the products high. For Opernfire and Smack, the policy seems to be pretty strict, as Jive Software needs a properly working Openfire Trunk for their commercial product.
    
    I wold suggest to address the patches to someone with commit rights to the Openfire Trunk, like akrherz, or guus and send the contributors agreement to Jive and Guus/akrherz via mail. I think it is wise to have patch reviews prior commits to the trunk.
    
    Walter
    
    Report Abuse
    
    Like (0)
    - wroot
      6,839 posts since
      Jan 24, 2005
      
      Currently Being Moderated
      
      Jun 23, 2009 1:09 AM (in response to Walter Ebeling)
      Re: Is it possible to SVN commit? How do I obtain the access?
      
      SVN commit policy is strict but it is possible to come through We need professionals willing to improve Openfire and other projects. There are some docs in the works which will describe an idea of mentoring. These docs should be released soon. This means, that at first a new contributor will have to earn trust from other SVN commiters (mentors) and then eventually he will get SVN commit rights and become a mentor himself.
      
      Report Abuse
      
      Like (0)
  - slushpupie
    776 posts since
    Jan 27, 2006
    
    Currently Being Moderated
    
    Jul 7, 2009 6:15 AM (in response to lkh007)
    Re: Is it possible to SVN commit? How do I obtain the access?
    
    Nothing really requires a contributer to be in the US, the agreement you have to sign is to keep a single copyright holder for the project to make certain legal situations easier. Admittedly this makes it a little more complicated for international would-be contributers, but there isnt much we can do about that.
    
    I wrote the initial document describing the steps needed to become a contributor with SVN access, and once we get a few revisions in we should be good to go with it.
    
    Report Abuse
    
    Like (0)